----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122854/#review77879 -----------------------------------------------------------
Ship it! Ship It! - Torsten Rahn On März 10, 2015, 4:34 vorm., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122854/ > ----------------------------------------------------------- > > (Updated März 10, 2015, 4:34 vorm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > We should compare GeoDataLinearRing's of different GeoDataPolygon's, not > one with itself. Check that in TestEquality::polygonTest(). > > Issue detected by Cppcheck: "Same expression on both sides of '!='." > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataPolygon.cpp 9ae7091 > tests/TestEquality.cpp a3f5498 > > Diff: https://git.reviewboard.kde.org/r/122854/diff/ > > > Testing > ------- > > Build marble, make sure TestEquality fails unless patch is applied. > > > Thanks, > > Boris Egorov > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
