----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122854/ -----------------------------------------------------------
(Updated March 21, 2015, 1:51 p.m.) Status ------ This change has been marked as submitted. Review request for Marble. Changes ------- Submitted with commit 7789e9748a4df0cd265b5f0aeb876b548e6a9a46 by Boris Egorov to branch master. Repository: marble Description ------- We should compare GeoDataLinearRing's of different GeoDataPolygon's, not one with itself. Check that in TestEquality::polygonTest(). Issue detected by Cppcheck: "Same expression on both sides of '!='." Diffs ----- src/lib/marble/geodata/data/GeoDataPolygon.cpp 9ae7091 tests/TestEquality.cpp a3f5498 Diff: https://git.reviewboard.kde.org/r/122854/diff/ Testing ------- Build marble, make sure TestEquality fails unless patch is applied. Thanks, Boris Egorov
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
