On Fri, Jul 25, 2008 at 09:30:19PM +0200, Jehan wrote: > This is why, if I can avoid #ifdef, I really prefer to.
I agree -- however some users still use mrxvt in very different situations (e.g. without Xft). Usually if the major #ifdef work is done in some function, which is completely surrounded by #ifdef/#endif, then it's not so bad. It gets a pain if the #ifdef's have to appear mid statement... > And if this is about mandatory dependency, I don't see any reason why > you would mess the code with #ifdef. Xft isn't mandatory, so libiconv as a result isn't mandatory. You should of course feel free to remove any #ifdef's that refer to mandatory dependencies. The only reason to keep them is in case you might want to remove the dependency later... Depending on the changes you make, if the UTF8 code is too complicated to #ifdef out, then don't worry. But if it's possible, a #ifdef would be nice. GI -- 100 THINGS I'D DO IF I EVER BECAME AN EVIL OVERLORD 20. Despite its proven stress-relieving effect, I will not indulge in maniacal laughter. When so occupied, it's too easy to miss unexpected developments that a more attentive individual could adjust to accordingly.
pgpQufFPUWVpS.pgp
Description: PGP signature
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Materm-devel mailing list Materm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/materm-devel mrxvt home page: http://materm.sourceforge.net
