Hello all, ok Gautam, so I think we agree. :-)
For the code of mrxvt, I think I understood most of it (in the main lines I mean), but the only code which remains mysterious to me is the code for fonts in fact. There are still some behaviours I don't understand in my tests. I am currently documenting on all the fonts stuffs. For the rest of it, I think I have it all and I know (in the main lines once again) how I will change mrxvt. I will try to change to a design to be the most "general" possible about encoding so that mrxvt will be able to either be able to encode in anything without us to even know it, or at least to be easily extensible... The "funny" thing is that I would like to work first on the fonts, which is the display stuff, of course! Because if I can have utf8, the display will be the easier way to check I managed it (there are other ways, but that's less rewarding -- for the less to say! -- and more boring I guess). So as far as I get this part too, I hope I will get something fastly. Do one of you know well the part about displaying fonts? Jehan P.S.: and as I have digged in the whole code of mrxvt, I have begun on the side to draw a small graphics about the working of mrxvt and the main functions each "part" of mrxvt corresponds to. I will complete this by basic explanations and comments on every part. This way it shall be pretty easy for any new contributor afterwhile to understand mrxvt and improve or fix part of it. Gautam Iyer a écrit : > On Fri, Jul 25, 2008 at 09:30:19PM +0200, Jehan wrote: > >> This is why, if I can avoid #ifdef, I really prefer to. > > I agree -- however some users still use mrxvt in very different > situations (e.g. without Xft). > > Usually if the major #ifdef work is done in some function, which is > completely surrounded by #ifdef/#endif, then it's not so bad. It gets a > pain if the #ifdef's have to appear mid statement... > >> And if this is about mandatory dependency, I don't see any reason why >> you would mess the code with #ifdef. > > Xft isn't mandatory, so libiconv as a result isn't mandatory. > > You should of course feel free to remove any #ifdef's that refer to > mandatory dependencies. The only reason to keep them is in case you > might want to remove the dependency later... > > Depending on the changes you make, if the UTF8 code is too complicated > to #ifdef out, then don't worry. But if it's possible, a #ifdef would be > nice. > > GI > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Materm-devel mailing list > Materm-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/materm-devel > mrxvt home page: http://materm.sourceforge.net ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Materm-devel mailing list Materm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/materm-devel mrxvt home page: http://materm.sourceforge.net
