Manuel Metz wrote:
> Jae-Joon Lee wrote:
>> Hi Manuel,
>>
>> I think it is a good to introduce the update_from method in Collections.
>> But, I'm not sure if it is a good idea to also update sizes, paths and
>> rotation (in RegularPolyCoolection). My impression is that update_from
>> method is to update gc related attributes. For comparison,
>> Patch.update_from() does not update the path.
>
> That's exactly the point why I wasn't fully happy with the patch. The
> path is generated by the _path_generator, so instead of copying the path
> it seems to be better to create an instance of the corresponding class
> (e.g. the StarPolygonCollection class, as suggested before).
>
> One should update the rotation attribute (!!); it's only one number. A
> '+' marker, for example, has rotation = 0, whereas a 'x' marker has
> rotation=pi/4. That's the only difference between those two !
>
>> Also, is it okay to update properties without checking its length?. It
>> does not seem to cause any problems though.
>
> It's in principal not a problem to copy the sizes attribute without
> checking the length. If it's shorter the the number of items the sizes
> are repeated; if it's longer it gets truncated.
>
> mm
>
>> I guess It would better to use xdata_markers than xdata in the
>> get_handle() method. The difference is when numpoints==1. Using xdata
>> gives two marker points.
>>
>> I was actually about to to commit my patch. I'll try to account your
>> changes and post my version of patch later today.
>>
>> Regards,
>>
>> -JJ
>>
>>
>>
>>
>> On Wed, Oct 15, 2008 at 4:07 PM, Manuel Metz <[EMAIL PROTECTED]> wrote:
>>> hmm
>>>
>>> -------- Original Message --------
>>> Jae-Joon Lee wrote:
>>>>> - the parameter numpoints should be used (it's ignored right now)
>>>>>
>>>> Thanks Manuel. I guess we can simply reuse xdata_marker for this purpose.
>>>>
>>>>
>>>>> - Some private variables are accessed and a new RegularPolycollection is
>>>>> created (does this work eg. with a StarPolygonCollection? I haven't
>>>>> checked, but I don't think so !). Instead of creating a new
>>>>> RegularPolyCollection it might be more useful to make a copy of the
>>>>> existing object... I was thinking about a update_from() method for the
>>>>> Collection class(es) similar to update_from() for lines.
>>>>>
>>>> By changing "RegularPolyCoolection" to "type(handles)", it works for
>>>> StarPolygonCollection.
>>>>
>>>> In Erik's current implementation, the markers in the legend have
>>>> varying colors, sizes, and y offsets.
>>>> The color variation seems fine. But do we need to vary the sizes and
>>>> y-offsets? My inclination is to use a fixed size (median?) and a fixed
>>>> y offset. How does Erik and others think?
>>>>
>>>> Regards,
>>>>
>>>> -JJ
>>> Attached is my current version of the patch. I've moved all of the
>>> properties-copying stuff to collections, which makes the changes
>>> legend.py more clearer (but I'm not fully happy with the patch and
>>> haven't commit anything yet)
>>>
>>> mm
>>>
Hi Jae-Joon,
so here is my revised version of the patch. What do you think ?
Manuel
Index: legend.py
===================================================================
--- legend.py (revision 6216)
+++ legend.py (working copy)
@@ -306,15 +306,14 @@
ret.append(legline)
elif isinstance(handle, RegularPolyCollection):
- if self.numpoints == 1:
- xdata = np.array([left])
- p = Rectangle(xy=(min(xdata), y-3/4*HEIGHT),
- width = self.handlelen, height=HEIGHT/2,
- )
- p.set_facecolor(handle._facecolors[0])
- if handle._edgecolors != 'none' and len(handle._edgecolors):
- p.set_edgecolor(handle._edgecolors[0])
- self._set_artist_props(p)
+ ydata = (y-HEIGHT/2)*np.ones(np.asarray(xdata_marker).shape, float)
+
+ p = type(handle)(handle.get_numsides(),
+ offsets=zip(xdata_marker,ydata),
+ transOffset=self.get_transform())
+
+ p.update_from(handle)
+ p.set_figure(self.figure)
p.set_clip_box(None)
p.set_clip_path(None)
ret.append(p)
Index: collections.py
===================================================================
--- collections.py (revision 6216)
+++ collections.py (working copy)
@@ -148,6 +148,12 @@
result = result.inverse_transformed(transData)
return result
+ def get_window_extent(self, renderer):
+ bbox = self.get_datalim(transforms.IdentityTransform())
+ #TODO:check to ensure that this does not fail for
+ #cases other than scatter plot legend
+ return bbox
+
def _prepare_points(self):
"""Point prep for drawing and hit testing"""
@@ -413,7 +419,19 @@
else:
self._edgecolors = self.to_rgba(self._A, self._alpha)
+ def update_from(self, other):
+ 'copy properties from other to self'
+ artist.Artist.update_from(self, other)
+ self._antialiaseds = other._antialiaseds
+ self._edgecolors_original = other._edgecolors_original
+ self._edgecolors = other._edgecolors
+ self._facecolors_original = other._facecolors_original
+ self._facecolors = other._facecolors
+ self._linewidths = other._linewidths
+ self._linestyles = other._linestyles
+ self._pickradius = other._pickradius
+
# these are not available for the object inspector until after the
# class is built so we define an initial set here for the init
# function and they will be overridden after object defn
@@ -686,6 +704,7 @@
"""
Collection.__init__(self,**kwargs)
self._sizes = sizes
+ self._numsides = numsides
self._paths = [self._path_generator(numsides)]
self._rotation = rotation
self.set_transform(transforms.IdentityTransform())
@@ -702,7 +721,16 @@
def get_paths(self):
return self._paths
+ def get_numsides(self):
+ return self._numsides
+ def update_from(self, other):
+ Collection.update_from(self, other)
+
+ self._numsides = other._numsides
+ self._sizes = other._sizes
+ self._rotation = other._rotation
+
class StarPolygonCollection(RegularPolyCollection):
"""
Draw a collection of regular stars with *numsides* points."""
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
