I share Tobias' and Chris' concerns, but I also agree with Markus. Do one-liners (or "few-liners") need a review? And who is to assign to those reviews? And how many? A set of guidelines to create reviews is as important as a set of guidelines to write code. Good practices, I mean.
2012/4/25 Markus Moormann <[email protected]> > Hi, > > I admit that I rarely created reviews. The question is: When do I create a > review? A lot of those tickets in the list below were fixed by me and were > often 1 - 10 lines of code that were added/deleted, of which there are a > lot of lines without any logic. Of course I can create a review on every > ticket i fixed but than this will lead to a lot of extra work. I think we > need a guideline (or is there already one?) which defines when to create a > review. I think new features should always be reviewed where as fixes for > a bug are difficultly to categorize. > > Markus > > > Hi Chris, > > > > thanks for bringing this up, as the lack of review of code amongst the co > > mitter is concerninh to me, too. > > > > From my point of view, it's not the tool itself, but a lack of interest > in > > providing insight into one's work, most probably coupled with a lack of > > resources when it comes to taking feedback and integrating it into the > > code. I see people pushing in new features and the immediately move on to > > new stuff. These features have usually not been discussed on list, nor > are > > they being reviewed, which on my opinion is a guarantee that both > > Matterhorn's overall architecture and code quality will ceise to exist > > and/or decrease even further. > > > > I am happy hearing suggestions from other committers pn why they don't > > offer their code for review, also what could be done in their opinion to > > yield more reviews and preliminary discussion around new features. > > > > Tobias > > > > On 25.04.2012, at 00:40, Christopher Brooks <[email protected]> > wrote: > > > >> Hi all, for 1.4 so far we have had the following crucible reviews > >> filed: > >> > >> CR-MH-442 > >> CR-MH-441 > >> CR-MH-440 > >> > >> And the following tickets completed (or worked on): > >> > >> Merging fixes for MH-7981, MH-7361, and MH-8736 into 1.4.x > >> Merging fix for MH-8614 into 1.4.x > >> Merging fix for MH-8613 into 1.4.x > >> Merging fix for MH-8750 into 1.4.x > >> Merging fix for MH-8769 into 1.4.x > >> Merging fix for MH-8620 into 1.4.x > >> Merging fix for MH-8739 into 1.4.x > >> Merging fix for MH-8758 into 1.4.x > >> Merging updated fix for MH-6312 into 1.4.x, with modification to build > >> 1.4.x VMs rather than trunk. > >> Merging fix for MH-8755 into 1.4.x > >> Merging fix for MH-8728 into 1.4.x, Felix is now integrated into branch. > >> Merging fix for MH-8709 into 1.4.x > >> Merging fix for MH-8704 into 1.4.x > >> Merging fix for MH-8485 into 1.4.x > >> Merging fix for MH-8689 into 1.4.x > >> Merging fix for MH-8738 into 1.4.x > >> Merging fix for MH-8732 into 1.4.x > >> Merging fix for MH-6856 and MH-8693 into 1.4.x > >> Merging fix for MH-8742 into 1.4.x > >> Merging fix for MH-8746 into 1.4.x > >> MH-8740 - Removed unnecessary dependancy. > >> Merging fix for MH-8723 into 1.4.x > >> Merging fix for MH-8714 into 1.4.x > >> Merging fix for MH-8710 into 1.4.x. > >> Merging fix for MH-8727 into 1.4.x > >> Merging fix for MH-8725 into 1.4.x > >> Merging fix for MH-8697 into 1.4.x > >> > >> These two lists should be much closer to even. What's the issue with > >> people not filing reviews? We can't seem to get any traction here, is > >> there just no interest in it? Are people unwilling to review other > >> tickets? Is cru too shitty of a tool for it? > >> > >> I think reviews make for better software, and make for better > >> programmers. But we don't do them; how come? > >> > >> Chris > >> -- > >> Christopher Brooks, BSc, MSc > >> ARIES Laboratory, University of Saskatchewan > >> > >> Web: http://www.cs.usask.ca/~cab938 > >> Phone: 1.306.966.1442 > >> Mail: Advanced Research in Intelligent Educational Systems Laboratory > >> Department of Computer Science > >> University of Saskatchewan > >> 176 Thorvaldson Building > >> 110 Science Place > >> Saskatoon, SK > >> S7N 5C9 > >> _______________________________________________ > >> Matterhorn mailing list > >> [email protected] > >> http://lists.opencastproject.org/mailman/listinfo/matterhorn > >> > >> > >> To unsubscribe please email > >> [email protected] > >> _______________________________________________ > > _______________________________________________ > > Matterhorn mailing list > > [email protected] > > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > > > > To unsubscribe please email > > [email protected] > > _______________________________________________ > > > > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________ >
_______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
