Ruben, > one-liners (or "few-liners") need a review? And who is to assign to > those reviews? And how many? A set of guidelines to create reviews is > as important as a set of guidelines to write code. Good practices, I
As far as who to assign to, I think any committer is fine. If you think they might be interested in that unit of code then add them to the review. They might not all finish reviews, but hopefully enough will. And I would aim for no more than 6 people on a review. When we started I tended to shotgun and assign everyone to a review so that everyone would see it. Now I try to target more towards people's skills. For CA stuff that tends to be assigning reviews to greg, adam, waldamir, and you, for instance. For HTML stuff I might hit up markus and micah. Etc. Chris -- Christopher Brooks, BSc, MSc ARIES Laboratory, University of Saskatchewan Web: http://www.cs.usask.ca/~cab938 Phone: 1.306.966.1442 Mail: Advanced Research in Intelligent Educational Systems Laboratory Department of Computer Science University of Saskatchewan 176 Thorvaldson Building 110 Science Place Saskatoon, SK S7N 5C9 _______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
