Hi Markus, > I admit that I rarely created reviews. The question is: When do I > create a review? A lot of those tickets in the list below were fixed > by me and were often 1 - 10 lines of code that were added/deleted, of > which there are a lot of lines without any logic. Of course I can > create a review on every ticket i fixed but than this will lead to a > lot of extra work. I think we need a guideline (or is there already
My rule of thumb is that whenever I don't want to be blamed for something that might happen I create a review and assign it to someone else on the team. That doesn't absolve me from blame, but it at least it cuts things down a bit :) Perhaps more seriously, I agree that there are lots of times we don't need reviews and it's tough. Any new feature I think should be reviewed somewhere, though that may have been done earlier. Anything more than half a dozen lines I tend to get reviews created for - something that big, if it were in Java, likely required another unit test to be written anyways. Javascript/html, I agree, are much more difficult to judge. Chris -- Christopher Brooks, BSc, MSc ARIES Laboratory, University of Saskatchewan Web: http://www.cs.usask.ca/~cab938 Phone: 1.306.966.1442 Mail: Advanced Research in Intelligent Educational Systems Laboratory Department of Computer Science University of Saskatchewan 176 Thorvaldson Building 110 Science Place Saskatoon, SK S7N 5C9 _______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
