Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/159203

Change subject: Both notifyNewTopic and notifyPostChange trigger mention notif
......................................................................

Both notifyNewTopic and notifyPostChange trigger mention notif

When posting a new topic with a reply, it would trigger two identical
mention notifications. We don't need to trigger it in new topic because
it will be always covered by the post change

Change-Id: I3d58f6391d953401a65a89e4b10530f36b83c563
---
M includes/Notifications/Controller.php
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/03/159203/1

diff --git a/includes/Notifications/Controller.php 
b/includes/Notifications/Controller.php
index 8c83f51..604fecc 100644
--- a/includes/Notifications/Controller.php
+++ b/includes/Notifications/Controller.php
@@ -207,16 +207,6 @@
                        )
                ) );
 
-               $events = array_merge( $events,
-                       $this->notifyNewPost( array(
-                               'title' => $boardWorkflow->getArticleTitle(),
-                               'user' => $user,
-                               'post' => $firstPost,
-                               'topic-title' => $topicTitle,
-                               'topic-workflow' => $topicWorkflow,
-                       ) )
-               );
-
                return $events;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/159203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d58f6391d953401a65a89e4b10530f36b83c563
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to