EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159913
Change subject: Both notifyNewTopic and notifyPostChange trigger mention notif
......................................................................
Both notifyNewTopic and notifyPostChange trigger mention notif
When posting a new topic with a reply, it would trigger two identical
mention notifications. We don't need to trigger it in new topic because
it will be always covered by the post change
(cherry picked from commit 1c0ce37b74195e761ab4d281c41c06f082d1f01b)
Change-Id: I3d266acdf0421fa0b378a08f5c5e46e622f1be3d
---
M includes/Notifications/Controller.php
1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/13/159913/1
diff --git a/includes/Notifications/Controller.php
b/includes/Notifications/Controller.php
index 310d71b..fe96f46 100644
--- a/includes/Notifications/Controller.php
+++ b/includes/Notifications/Controller.php
@@ -207,16 +207,6 @@
)
) );
- $events = array_merge( $events,
- $this->notifyNewPost( array(
- 'title' => $boardWorkflow->getArticleTitle(),
- 'user' => $user,
- 'post' => $firstPost,
- 'topic-title' => $topicTitle,
- 'topic-workflow' => $topicWorkflow,
- ) )
- );
-
return $events;
}
--
To view, visit https://gerrit.wikimedia.org/r/159913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d266acdf0421fa0b378a08f5c5e46e622f1be3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: wmf/1.24wmf20
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
