jenkins-bot has submitted this change and it was merged.
Change subject: Both notifyNewTopic and notifyPostChange trigger mention notif
......................................................................
Both notifyNewTopic and notifyPostChange trigger mention notif
When posting a new topic with a reply, it would trigger two identical
mention notifications. We don't need to trigger it in new topic because
it will be always covered by the post change
Change-Id: I3d58f6391d953401a65a89e4b10530f36b83c563
(cherry picked from commit 1c0ce37b74195e761ab4d281c41c06f082d1f01b)
---
M includes/Notifications/Controller.php
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Notifications/Controller.php
b/includes/Notifications/Controller.php
index d3cfc92..f9cfd7e 100644
--- a/includes/Notifications/Controller.php
+++ b/includes/Notifications/Controller.php
@@ -207,16 +207,6 @@
)
) );
- $events = array_merge( $events,
- $this->notifyNewPost( array(
- 'title' => $boardWorkflow->getArticleTitle(),
- 'user' => $user,
- 'post' => $firstPost,
- 'topic-title' => $topicTitle,
- 'topic-workflow' => $topicWorkflow,
- ) )
- );
-
return $events;
}
--
To view, visit https://gerrit.wikimedia.org/r/159910
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d58f6391d953401a65a89e4b10530f36b83c563
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: wmf/1.24wmf20
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
