On 09/20/2010 11:54 AM, ext Felipe Contreras wrote:
On Mon, Sep 20, 2010 at 11:14 AM, Ross Burton<r...@linux.intel.com> wrote:
On Sat, 2010-09-18 at 20:11 +0300, Felipe Contreras wrote:
That's not integrated with git at all; it's a separate service that
requires a authentication, you have to interrupt what you are doing in
order to login and review patches, plus it's not like you are
constantly checking gitorious, right?
The merge requests appear to be implemented as references that are not
normally fetched by git. I just merged a change that was submitted in
gitorious by doing:
$ git pull git://gitorious.org/gupnp/gupnp.git refs/merge-requests/2
I expect adding refs/merge-requests/* to origin.fetch in .git/config
would "integrate" the merge requests fairly well, although I doubt they
close merge requests when the commits are merged directly into master.
That's interesting, but it's one way; you can't review and send
comments back, or send the patches back with modifications.
You can submit modifications by pushing back to the same ref. Using a
set of aliases and scripts I've got a pretty nice workflow set up for
pushing and pulling requests, but you do still have to use the web front
end for some things.
The actual Gitorious review tools are merely okay-ish, but we've
processed some 1000 requests for the MeeGo Touch projects since moving
to the new repositories. Before this we were however using Review Board,
and it's a significantly better tool for your typical back-and-forth
review, with proper nested comments and line-by-line and block
commenting that actually works.
So, +1 for reviewboard.meego.com, would be really great if it could be
set up to integrate with the gitorious repositories and user groups.
Regards,
Tomas
_______________________________________________
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev
