On Fri, Sep 24, 2010 at 8:00 AM, Sateesh Babu <sateesh.kav...@gmail.com> wrote: > On Fri, Sep 24, 2010 at 3:01 AM, Ryan Ware <ryan.r.w...@intel.com> wrote: >> In the cases which do readily exist for code submissions directly into >> MeeGo, the mail list format works exceedingly well. It has worked for >> large, dynamic projects for a long period of time and has a track record >> that can be predicted and relied upon. No, it's not perfect, but as the >> person responsible for ensuring security defects are corrected in a >> timely and responsive manner, I think the track record shows that mail >> lists find a large percentage of the issues while the other tools >> mentioned in this thread don't have a similar extensive track record. > > But why to enforce only email review, when there is also a group that is > interested in review tools. Review of patches is fine, but a tool like > reviewboard > provides a complete context of the code change and some nice features of > easy commenting.
IMO it's fine if it's a MeeGo only group, but what if you want the patches to be reviewed upstream and they don't like reviewboard, or they have their own tools? This is what I mean when I say reviewboard and bugzilla are not distributed. Supposing you have a mailing list that is properly configured: 1) Reply-To munging is not used 2) Non-subscriber posts are allowed (moderated) 3) Patches are welcome Then you can really exploit the power of patch reviewing through email in a distributed manner. For example you can send patches to meego-kernel, linux-omap and linux-kernel, the review comments would be available to everybody in all the mailing lists. This is just not possible with reviewboard. > A track record cannot be created unless and the new tool is tried out :) Reviewboard has been out there since quite some time, maybe people have tried it out; it just doesn't have enough traction. -- Felipe Contreras _______________________________________________ MeeGo-dev mailing list MeeGo-dev@meego.com http://lists.meego.com/listinfo/meego-dev
