On Fr, 2011-05-06 at 14:08 +0100, Dumez, Christophe wrote: > Please find attached another set of patches for QtContacts-EDS engine: > #0001: Support filtering for all contact details. For those that are not > directly supported by libebook, use a fallback mechanism: Fetch all contacts > from EDS and do post filtering. Update the unit tests to check the fallback > mechanism. Note that one test is disabled due to the following QtMobility > limitation: http://bugreports.qt.nokia.com/browse/QTMOBILITY-1623
Merged. One question: Connie mentioned on chat that the MeeGo UX filters on the boolean QContactFavorite. I suspect that this is a detail which we store in EDS as X-EDS-QTCONTACTS extensions and therefore filtering is happening entirely client-side, right? If you see a chance to execute this filter on the EDS server side, then go for it. Perhaps we can add an explicit mapping "QContactFavorite = X-EDS-QTCONTACTS-FAVORITE;X-EDS-QTCONTACTS-INDEX=<index>:0/1" and then filter by "field equals"? > #0002: Use QCOMPARE in the unit tests instead of QVERIFY for integer > comparison (More helpful output in case of failure) Merged. > #0003: Remove unused macro function copied from the Maemo backend Merged. > #0004: saveContact() Update the contact's managerURI only if it was saved > successfully > #0005: saveContact() Make sure the contact does not belong to another manager > before trying to save/update it Both merged. This was probably already missing in the Maemo 5 backend, right? Once you are done with the code, we should get it reviewed by real QtContacts experts. For example, someone on #qtcontacts-tracker (phako = Jens Georg, if memory serves me right) mentioned that the contacts()->contact() fallback is redundant now. QtMobility added that same loop to the core class after the Maemo 5 backend was written. Our backend should either remove the dummy contacts() implementation or provide a real implementation which fetches multiple contacts at once. Same for saving. > #0006: saveContact() Validate the contact before updating its display name Merged. > I noticed that QContactEBook does not actually make use of libebook's > asynchronous requests (for saving, removing contacts). It merely > emulates support for it (but actually calls the synchronous > saveContacts() / removeContacts() methods internally). I would like to > work on that if that's OK, and by the same occasion clean this part of > the code. Agreed. See my earlier comments. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ MeeGo-dev mailing list [email protected] http://lists.meego.com/listinfo/meego-dev http://wiki.meego.com/Mailing_list_guidelines
