On So, 2011-05-08 at 09:56 -0700, Dumez, Christophe wrote: > Hi, > > Please find attached a few more patches for QtContacts EDS backend: > 0001: QContactEBook::removeContact() eContact pointer check
Merged. > 0002: Engine: support for contact change timestamp. Bring support for > QContactTimestamp::FieldModificationTimestamp and add unit tests to > check it. How many individual tests should there be in bin/tests? I see: # bin/tests -functions testAddContactUpdateTimeStamp() testRemoveContact() It's probably just my ignorance of the Qt testing framework. I was looking for a way to run individual tests, because right now the first one hangs for me: # bin/tests ********* Start testing of BasicTest ********* Config: Using QTest library 4.7.2, Qt 4.7.2 PASS : BasicTest::initTestCase() FAIL! : BasicTest::testAddContactUpdateTimeStamp() '! timestamp.isEmpty()' returned FALSE. () Loc: [ut_basic/basictest.cpp(48)] (process:20224): libebook-CRITICAL **: file e-book.c: line 1534 (e_book_remove_contact_async): assertion `E_IS_CONTACT (contact)' failed ^CQFATAL : BasicTest::testRemoveContact() Received signal 2 FAIL! : BasicTest::testRemoveContact() Received a fatal error. Loc: [Unknown file(0)] Totals: 1 passed, 2 failed, 0 skipped ********* Finished testing of BasicTest ********* Aborted I'm merging this anyway, because the code is still unstable anyway and we can clean this up in the master branch. > 0003: QContactEbook: Improved error handling / reporting in contact > conversion code. Merged. I'm wondering: is there some (easy?) way of mapping an error code seen at the API level to a problem in the qtcontacts-eds source code or EDS itself? Looks like the debug output is the only way to do that. We should add a README file to QtContacts-EDS which explains that setting the QCONTACT_EBOOK_DEBUG env variable to a non-empty string enables debugging. This is what the Maemo 5 backend did. When I saw it, I wondered about it a bit: should such debug output be left enabled in a release build? It goes against software engineering guidelines (disable unnecessary, untested code), but in this case it is really useful. > 0004: QContactEbook: improved jobSharedData management (Improved > memory handling + double-free fix in destructor) Merged. > 0005: QContactEBook::selfContactId() Correctly report errors > (QContactManager::DoesNotExistError if the contact > returned is not from the current EBook) Merged. > 0006: QContactEBookEngine::isFilterSupported() Correctly report Action > filters as not being supported. Merged. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ MeeGo-dev mailing list [email protected] http://lists.meego.com/listinfo/meego-dev http://wiki.meego.com/Mailing_list_guidelines
