Hi hi,

Again, as Maitrey says, this could have been discussed better directly
in bugzilla (BMC, not BOO, whatever that is) or in a mailing list,
instead of quietly pushing a patch without notifying anyone. At least
this time there is little chance of regressions with that patch.

> Yet again, I see that the patches to tracker are integrated to
> MeeGo1.2 without discussing with the developers or even notifying the
> maintainers.
> 
> Tracker is maintained in devel:contentfw.
> 
> In particular,
> http://build.meego.com/package/view_file?file=tracker.changes&package=tracker&project=MeeGo%3A1.2%3Aoss&srcmd5=fdc04640e591b56eb225259df767f9d7
>  
> the changelog shows BOO#9769. I do not see this bug in
> https://bugs.meego.com with respect to tracker.
> 

So, the ChangeLog for this last patch that was integrated is the
following:
        * Fri Jul 15 2011 Xiaoming Si <[email protected]> -
        0.10.6  
        - Set the locale env before checking it (BOO#9769)

Link to the patch:
http://build.meego.com/package/view_file?file=0008-Set-locale-env-before-checking.patch&package=tracker&project=MeeGo%3A1.2%3Aoss&srcmd5=fdc04640e591b56eb225259df767f9d7

And the patch is just doing:
-   if (g_getenv (TRACKER_DISABLE_MEEGOTOUCH_LOCALE_ENV)) {  
+    g_setenv(TRACKER_DISABLE_MEEGOTOUCH_LOCALE_ENV, "1", TRUE);      
+    if (g_getenv (TRACKER_DISABLE_MEEGOTOUCH_LOCALE_ENV)) {  
        g_message ("Retrieving locale from GConf is DISABLED");  


IIRC, there was a request to avoid depending on libmeegotouch in
Tracker. So why not just use --disable-meegotouch during configure? It
seems a much much much cleaner option than that patch.

Cheers,

-- 
Aleksander

_______________________________________________
MeeGo-packaging mailing list
[email protected]
http://lists.meego.com/listinfo/meego-packaging

Reply via email to