lothiraldan accepted this revision.
lothiraldan added a comment.
It looks good to me.
I did some quick and dirty performance check and I see a performance
improvement. On the mozilla-central repository, without this change, I get
these results:
$ python -m perf command /home/lothiraldan/project/mercurial/mercurial/hg
id -r .
.....................
command: Mean +- std dev: 154 ms +- 2 ms
$ python -m perf command /home/lothiraldan/project/mercurial/mercurial/hg
id -r .
.....................
command: Mean +- std dev: 154 ms +- 2 ms
$ python -m perf command /home/lothiraldan/project/mercurial/mercurial/hg
id -r .
.....................
command: Mean +- std dev: 156 ms +- 3 ms
And with this changeset I get better results:
$ python -m perf command /home/lothiraldan/project/mercurial/mercurial/hg
id -r .
.....................
command: Mean +- std dev: 119 ms +- 3 ms
$ python -m perf command /home/lothiraldan/project/mercurial/mercurial/hg
id -r .
.....................
command: Mean +- std dev: 120 ms +- 3 ms
$ python -m perf command /home/lothiraldan/project/mercurial/mercurial/hg
id -r .
.....................
command: Mean +- std dev: 123 ms +- 7 ms
Where perf is https://perf.readthedocs.io/en/latest/
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1253
To: durham, #hg-reviewers, lothiraldan
Cc: lothiraldan, mharbison72, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
