yuja added a comment.
Queued up to this patch, thanks.
INLINE COMMENTS
> dirstate.py:132
> (state, mode, size, time).'''
> - self._read()
> + self._map = dirstatemap(self._ui, self._opener, self._root)
> return self._map
Perhaps this can be moved to __init__() since calling dirstatemap()
doesn't do any IO now.
> dirstate.py:1209
> + self._map = {}
> + self.read()
> + return self._map
Nit: dirstatemap.read() could be a private function.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1253
To: durham, #hg-reviewers, lothiraldan, yuja
Cc: yuja, lothiraldan, mharbison72, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
