On Wed, May 25, 2016 at 8:51 AM, Emil Velikov <[email protected]> wrote: > On 25 May 2016 at 13:43, Rob Clark <[email protected]> wrote: >> On Wed, May 25, 2016 at 8:23 AM, Rob Herring <[email protected]> wrote: >>> On Tue, May 24, 2016 at 6:39 PM, Rob Clark <[email protected]> wrote: >>>> From: Rob Clark <[email protected]> >>>> >>>> Split standalone glsl_compiler into a libstandalone.la and a thin >>>> main.cpp. This way drivers can re-use the glsl standalone frontend in >>>> their own standalone compilers. >>>> >>>> Signed-off-by: Rob Clark <[email protected]> >>>> --- >>>> v2: fix scons build and fix automake hack >>>> >>>> src/compiler/Makefile.glsl.am | 16 +- >>>> src/compiler/Makefile.sources | 3 +- >>>> src/compiler/SConscript.glsl | 2 + >>> >>> Android changes? Looks like this will break things to me. >> >> It didn't look like android builds the standalone glsl_compiler (it >> isn't something that gets installed, and tbh I'm not entirely sure why >> scons does bother to build it..) >> >> So I think we should be ok for android build. >> > Everyone builds the glsl_compiler > $ git grep glsl_compile | egrep "Android|SCons|Makefile"
ugg, I guess grep fail on my part.. > Then again I'm not sure why Android/Scons bothers. Personally I'm not > going to object if we nuke them. ok, well I've fixed scons build already so might as well keep that for now (in case there is someone who only builds on windows?).. for android I don't see any point to keeping it, since it's a cross-compile build. I'll add a patch to drop glsl_compiler from android build. BR, -R > Thanks > Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
