On Wed 15 Mar 2017, Jason Ekstrand wrote: > Fun story: This will implicitly handle the (invalid) case of trying to > create a MCS for a 16xMSAA surface that's more than 8k wide. :-) We may > want to keep the check in init_mcs for clarity and because it's in the docs > but the extra validation is nice.
Nice. I like it when a concise, general case unexpectedly supercedes seemingly unrelated special cases. Let's do more of that in isl :) Leaving the validation in get_mcs_surf() is ok with me. The extra code and comment helps clarify things. But if someone does delete it, I'm ok with that too. _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
