On Wed, May 17, 2017 at 11:17 AM, Samuel Pitoiset <[email protected]> wrote: > This will also magically fix this special lowering for > bindless samplers. > > Signed-off-by: Samuel Pitoiset <[email protected]> > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c > b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c > index 13b46949d0..cd40d3eeaf 100644 > --- a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c > +++ b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c > @@ -1772,17 +1772,16 @@ static void build_tex_intrinsic(const struct > lp_build_tgsi_action *action, > /* The hardware needs special lowering for Gather4 with integer > formats. */ > if (ctx->screen->b.chip_class <= VI && > opcode == TGSI_OPCODE_TG4) { > - struct tgsi_shader_info *info = &ctx->shader->selector->info; > /* This will also work with non-constant indexing because of > how > * glsl_to_tgsi works and we intent to preserve that behavior. > */
This comment can be removed, because it talks about getting the return type from declarations. With my comments on patch 2 & 3 addressed, the series is: Reviewed-by: Marek Olšák <[email protected]> Marek _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
