On 08/08/2017 08:07 PM, Emil Velikov wrote:
On 8 August 2017 at 16:10, Eric Engestrom <eric.engest...@imgtec.com> wrote:
On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote:
From: Emil Velikov <emil.veli...@collabora.com>

As mentioned in previous commit the negative tests in dEQP expect the
arguments to be evaluated in particular order.
The spec doesn't say that, so the test is wrong.
Changing it in Mesa doesn't hurt though, so I have nothing against it,
except for the fact it hide the dEQP bug.

I agree, the spec does not say anything on the topic.
I think it makes sense to have the patch regardless, since it provides
a bit more consistency.

Although fixing dEQP is also a good idea. I think Tapani/Chad have
some experience/pointers on the topic.

You can send patches to gerrit in same manner just like for rest of Android, then assign reviewers from people that have committed to dEQP. I can help trying to get those fixes forward. You should work on master branch though, what I've experienced is that getting fixes to some specific release branch is a lot more difficult matter.

// Tapani

mesa-dev mailing list

Reply via email to