On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote:
> On 5 August 2017 at 00:25, Emil Velikov <emil.l.veli...@gmail.com> wrote:
> > From: Emil Velikov <emil.veli...@collabora.com>
> >
> > As mentioned in previous commit the negative tests in dEQP expect the
> > arguments to be evaluated in particular order.
> >
> > Namely - first the dpy, then the config, followed by the surface/window.
> >
> > Move the check further down or executing the test below will produce
> > the following error.
> >
> > dEQP-EGL.functional.negative_api.create_pbuffer_surface
> >
> >
> > <Section Name="Test2" Description="EGL_BAD_CONFIG is generated if config
> > is not an EGL frame buffer configuration">
> > <Text>eglCreateWindowSurface(0x9bfff0f150, 0xffffffffffffffff,
> > 0x0000000000000000, { EGL_NONE });</Text>
> > <Text>// 0x0000000000000000 returned</Text>
> > <Text>// ERROR expected: EGL_BAD_CONFIG, Got:
> > EGL_BAD_NATIVE_WINDOW</Text>
> > </Section>
> >
>
> FTR dEQP has been "fixed" (by removing the test all together) to not
> generate the above error. At the same the Pixman equivalent is still
> buggy, hence the v2 of commit
> df8efd5b74d45e2bfb977a92dcd3db86abd6b143.
>
Emil, does it mean this patch is superseded? I'm interesting in knowing
the situation as this was tagged to be included in stable release.
Thanks in advance.
J.A.
> I've sent patches [1] to restore the test and fix the buggy ones.
>
> As those land, I would love to have symmetrical Window/Pixman paths. Be that:
> - merging this patch (with polished commit message), or
> - updating the Window path to be like this one.
>
> I have no preference on which one ;-)
>
> Thanks
> Emil
>
> [1]
> https://android-review.googlesource.com/#/q/owner:emil.l.velikov%2540gmail.com
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
