On Fri, 2 Mar 2012 10:14:05 +0800, Yuanhan Liu <yuanhan....@linux.intel.com> wrote: > On Thu, Mar 01, 2012 at 09:54:46AM -0800, Eric Anholt wrote: > > On Thu, 23 Feb 2012 14:19:19 +0800, Yuanhan Liu > > <yuanhan....@linux.intel.com> wrote: > > > > > > + /* Handle gl_PointSize builtin var here */ > > > + if (ctx->Point._Attenuated || ctx->VertexProgram.PointSizeEnabled) > > > + EMIT_ATTR(_TNL_ATTRIB_POINTSIZE, EMIT_1F, S4_VFMT_POINT_WIDTH, 1); > > > > All the other EMIT_ATTRs specify the number of bytes as the last arg. > > It seems like this code shouldn't have worked. > > Actually, it does work ;) > > Well, if the last arg specify the size in _bytes_, then this patch was > wrong. > > And here is the updated one:
Reviewed-by: Eric Anholt <e...@anholt.net>
pgpPKg7tjiEG3.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
