Re: [Mesa-dev] tritemp.h

[Eero Pajarre]

emanuel stiebler wrote:
> 
> Hi,
> 
> I just noticed, that we call the macro "INNER_LOOP (left, right, iy);"
> even if there are no pixel to set.
> 
> I think, that:
> 
>     if (left != right)
>         INNER_LOOP (left, right, iy);
> 
> would be better.
> 
> Any comments ?
> 

All the definitions of the INNER_LOOP
seem to start with something like:
#define INNER_LOOP( LEFT, RIGHT, Y )                                    \
        {                                                               \
           GLint i, n = RIGHT-LEFT;                                     \
           GLdepth zspan[MAX_WIDTH];                                    \
           GLfloat lambda[MAX_TEXTURE_UNITS][MAX_WIDTH];                \
           if (n>0) {                                                   \
        -----   all the code is here-----
           }
        }

So I think the check would be sort of redundant.
(declaring local variables like zspan and lambda,
does not usually consume CPU time during the execution,
all the "work" is done during compile time)

                Eero


_______________________________________________
Mesa-dev maillist  -  [EMAIL PROTECTED]
http://lists.mesa3d.org/mailman/listinfo/mesa-dev