-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Tilman Sauerbeck wrote: > Hi, > I've been valgrinding around a bit lately, and noticed this: > > ==9215== 20 (16 direct, 4 indirect) bytes in 1 blocks are definitely lost in > loss record 8 of 22 > ==9215== at 0x401B4D1: malloc (in > /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so) > ==9215== by 0x412ADE6: driCreateDisplay (dri_glx.c:415) > ==9215== by 0x4103806: __glXInitialize (glxext.c:1207) > ==9215== by 0x40FD06E: GetGLXPrivScreenConfig (glxcmds.c:137) > ==9215== by 0x40FF56F: glXChooseVisual (glxcmds.c:1208) > ==9215== by 0x804A44E: mesa_hack (glxinfo.c:809) > ==9215== by 0x804A9AA: main (glxinfo.c:944) > > This is fixed by the attached patch. Was that chunk of code commented > out for a good reason or was it just forgotten to be enabled again? > Enabling it doesn't seem to have bad side effects for me.
It looks like something that was accidentally committed. Is there anything in the CVS log / history for that file? If there isn't anything specifically mentioned in the log, then it was probably an accident. > Index: src/glx/x11/glxext.c > =================================================================== > RCS file: /cvs/mesa/Mesa/src/glx/x11/glxext.c,v > retrieving revision 1.22 > diff -u -p -r1.22 glxext.c > --- src/glx/x11/glxext.c 12 Jul 2006 16:49:07 -0000 1.22 > +++ src/glx/x11/glxext.c 12 Jul 2006 16:54:00 -0000 > @@ -388,7 +388,7 @@ static int __glXFreeDisplayPrivate(XExtD > priv->serverGLXversion = 0x0; /* to protect against double free's */ > } > > -#if 0 /* GLX_DIRECT_RENDERING */ > +#if GLX_DIRECT_RENDERING > /* Free the direct rendering per display data */ > if (priv->driDisplay.private) > (*priv->driDisplay.destroyDisplay)(priv->dpy, -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFEtlzcX1gOwKyEAw8RAtq5AJ9sZ1hFUKxKyTLZTQKR4PBB7a4ypgCfY7uh xiAFKos4+BGSp4F05sHWuUQ= =tcDc -----END PGP SIGNATURE----- ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
