Ian Romanick [2006-07-13 07:46]: > Tilman Sauerbeck wrote: > > I've been valgrinding around a bit lately, and noticed this: > > > > ==9215== 20 (16 direct, 4 indirect) bytes in 1 blocks are definitely lost > > in loss record 8 of 22 > > ==9215== at 0x401B4D1: malloc (in > > /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so) > > ==9215== by 0x412ADE6: driCreateDisplay (dri_glx.c:415) > > ==9215== by 0x4103806: __glXInitialize (glxext.c:1207) > > ==9215== by 0x40FD06E: GetGLXPrivScreenConfig (glxcmds.c:137) > > ==9215== by 0x40FF56F: glXChooseVisual (glxcmds.c:1208) > > ==9215== by 0x804A44E: mesa_hack (glxinfo.c:809) > > ==9215== by 0x804A9AA: main (glxinfo.c:944) > > > > This is fixed by the attached patch. Was that chunk of code commented > > out for a good reason or was it just forgotten to be enabled again? > > Enabling it doesn't seem to have bad side effects for me. > > It looks like something that was accidentally committed. Is there > anything in the CVS log / history for that file? If there isn't > anything specifically mentioned in the log, then it was probably an > accident.
I found the commit: http://cvsweb.xfree86.org/cvsweb/xc/lib/GL/glx/glxext.c.diff?r1=1.2&r2=1.3 The commit comment just says: "3377. DRI megapatch. This moves mesa to xc/extras, updates Mesa to version 3.2, adds full support and fifo code for 3dfx hardware, and updates the device driver to work with Linux 2.3 kernels (#3463, Daryll Strauss)." What do we do now? :) Regards, Tilman -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail?
pgpm25RWfMSbN.pgp
Description: PGP signature
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
