Chris Rankin wrote:
> I think this patch is wrong - shouldn't it say:
>
> ! if (!mesa_vp->Base.String) { ! /* Spec says
> GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB is only zero if the ! *
> program (if it exists) exceeds hw limits. ! */ !
> vp->native = GL_TRUE; return GL_TRUE; /* <<<< HERE */ + }
>
> The bottom line is that my Xorg server locks up if I apply your patch
> and run
>
> $ WoW.exe -opengl
>
> but works OK if r200_translate_vertex_program() returns GL_TRUE if
> mesa_vp->Base.String is NULL.
You may have a point but I fail to see why it would make any difference
since the return value is never used currently anyway. Maybe you just
got lucky.
I hope there aren't any bugs wrt to submitting ill-specified /
half-setup vertex progs to the hardware, that could well lead to lockups
(though as long as vertex progs are not enabled it shouldn't be a
problem, except that it would overwrite the hardware tcl storage area
which would cause lockups too unless restored - the driver should deal
with that but there are already hacks to make it work).
Roland
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
