Eric, Gary,
This code looks like a re-implementation of the existing
do_texture_copypixels() from the i915 driver. It seems to do a similiar but
not-quite-the-same operation but by a divergent set of code changes.
Is there any reason not to have just ported the changes over from i915tex? I'd
strongly prefer to keep the two codebases as similar as possible - as you can
see in i915tex/ there is an increasing amount of non-chipset dependent code
(all the intel_* files) as we add more advanced features like FBO's etc. It
would be good to keep open the possibility of reunifying the codebases once
i965 has caught up with the memory manager changes, etc.
Keith
----- Original Message ----
From: Eric Anholt <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Sent: Wednesday, November 29, 2006 1:16:12 AM
Subject: [Mesa3d-cvs] CVS Update: Mesa (branch: trunk)
CVSROOT: /cvs/mesa
Module name: Mesa
Repository: Mesa/src/mesa/drivers/dri/i965/
Changes by: [EMAIL PROTECTED] 06/11/29 01:16:12
Log message:
Add accelerated CopyPixels for non-overlapping, 1:1 blits.
Submitted by Gary Wong <[EMAIL PROTECTED]>
Modified files:
Mesa/src/mesa/drivers/dri/i965/:
brw_context.c brw_context.h brw_metaops.c brw_tex.c
brw_vtbl.c brw_wm_surface_state.c intel_buffers.c
intel_context.h intel_pixel_copy.c intel_tex_validate.c
Revision Changes Path
1.4 +2 -0 Mesa/src/mesa/drivers/dri/i965/brw_context.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/brw_context.c
1.4 +5 -1 Mesa/src/mesa/drivers/dri/i965/brw_context.h
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/brw_context.h
1.2 +88 -10 Mesa/src/mesa/drivers/dri/i965/brw_metaops.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/brw_metaops.c
1.5 +32 -0 Mesa/src/mesa/drivers/dri/i965/brw_tex.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/brw_tex.c
1.3 +1 -0 Mesa/src/mesa/drivers/dri/i965/brw_vtbl.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/brw_vtbl.c
1.4 +6 -0 Mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
1.5 +1 -1 Mesa/src/mesa/drivers/dri/i965/intel_buffers.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/intel_buffers.c
1.8 +10 -1 Mesa/src/mesa/drivers/dri/i965/intel_context.h
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/intel_context.h
1.4 +65 -2 Mesa/src/mesa/drivers/dri/i965/intel_pixel_copy.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/intel_pixel_copy.c
1.4 +3 -0 Mesa/src/mesa/drivers/dri/i965/intel_tex_validate.c
http://webcvs.freedesktop.org/mesa/Mesa/src/mesa/drivers/dri/i965/intel_tex_validate.c
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mesa3d-cvs mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/mesa3d-cvs
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev