On Wed, Nov 29, 2006 at 01:57:00AM -0800, Keith Whitwell wrote:
> This code looks like a re-implementation of the existing
> do_texture_copypixels() from the i915 driver. It seems to do a
> similiar but not-quite-the-same operation but by a divergent set of
> code changes.
Oops.
> Is there any reason not to have just ported the changes over from
> i915tex?
No (except that I wasn't aware of the capability in that driver). It
seemed to me that the closest thing to CopyPixels through the i965 3D
pipeline was the i965 meta_ops Clear, so I used a similar approach to
that (except applying the per-fragment operations from the GL state,
and doing the texture-from-frame-buffer stuff).
> I'd strongly prefer to keep the two codebases as similar
> as possible - as you can see in i915tex/ there is an increasing
> amount of non-chipset dependent code (all the intel_* files) as we
> add more advanced features like FBO's etc. It would be good to keep
> open the possibility of reunifying the codebases once i965 has
> caught up with the memory manager changes, etc.
I agree.
How much work is involved in reunification, and which parts need to
be reconciled?
And what should I do -- I presume the best short-term approach is
for me to submit patches aligning my previous CopyPixels with the
i915tex version (i.e. expressed in terms of meta_import_pixel_state,
meta_tex_rect_source, etc.)?
Cheers,
Gary.
--
Gary Wong [EMAIL PROTECTED]
http://cs-people.bu.edu/gtw/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
