Rune Petersen wrote: >> I see that ctx->Point.Size is computed/updated via >> _mesa_update_state_locked(), but ctx->Line._Width is immediately >> updated in _mesa_LineWidth(). That's a bit inconsistant. >> >> It probably would be OK to compute ctx->Point._Size in >> _mesa_PointSize(). >> >> You might check the other drivers to see how they're handling line >> width and point size. >> > > looks like people are unsure of what to use. The preferred choice is > the most obvious choice: the width & size parameter. Any chance we > could make it the right choice? What do you mean by "make it the right choice"? Different drivers may have different needs. In particular, drivers implementing ARB_point_parameters (with hw tcl) cannot use a clamped value. Others not supporting ARB_point_parameters probably want to clamp it to hw limits (which should be the same as clamp to user limits in this case, if initialization was correct - which might not be the case, I know I encountered some problem with that in the r200 driver). r200 could (and maybe should, not that it matters much) use the size parameter instead of ctx.PointSize.
Roland > > Rune Petersen > > The results: ------------ > > gamma: LineWidth() - width (no clamping) PointSize() - size (no > clamping) > > i810: LineWidth() - Line._Width > > > i830+915: LineWidth() - width (clamping!) PointSize() - size > (clamping!) > > radeon: LineWidth() - width (no clamping) > > R200: LineWidth() - Line._Width PointSize() - Point.Size (no > clamping) > > R300: LineWidth() - Line._Width PointSize() - Point._Size > > nouveau: LineWidth() - width (no clamping) PointSize() - size (no > clamping) > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
