Xiang, Haihao wrote:
>> -----Original Message-----
>> From: [EMAIL PROTECTED]
>> [mailto:[EMAIL PROTECTED] On Behalf Of Roland
>> Scheidegger
>> Sent: 2007年3月14日 2:05
>> To: [EMAIL PROTECTED]
>> Subject: mesa: Branch 'master'
>>
>> src/mesa/drivers/dri/i965/brw_vs_tnl.c | 27 ++++++++++++---------------
>> src/mesa/tnl/t_vp_build.c | 12 +++++++-----
>> 2 files changed, 19 insertions(+), 20 deletions(-)
>>
>> New commits:
>> diff-tree a6cc9ab493a2efa9a0ea91cddba0e85c8c8c83f1 (from
>> 37e6f760fde506728077c6e8b48bb8c34d53dfd3)
>> Author: Roland Scheidegger <[EMAIL PROTECTED]>
>> Date: Tue Mar 13 19:04:28 2007 +0100
>>
>> sync up t_vp_build.c brw_vs_tnl.c a bit
>>
>> Bring over the optimizations for fog and normalized spot dir
>> from t_vp_build.c to brw_vs_tnl.c. Likewise, port a fix for point size
>> calc from brw_vs_tnl.c to t_vp_build.c (use ABS(eyez) instead of -eyez).
>> Leave
>> the now differing point size calcs alone though, not sure what's better
>> (it's
>> basically MOV, ABS, MUL, DP3 vs. ABS, MAD, MAD).
>
> It seems this commit impacts fog operation. Glean case "fragProg1" on 965
> gets the following message:
> FAILURE:
> Program: ARB_fog_linear test
> Expected color: 0.583333, 0.861111, 0.277778, 0.25
> Observed color: 0.984314, 0.996078, 0.0117647, 0.25098
> FAILURE:
> Program: ARB_fog_linear test
> Expected color: 0.583333, 0.861111, 0.277778, 0.25
> Observed color: 0.984314, 0.996078, 0.0117647, 0.25098
>
> If remove this commit, fragProg1 works fine.
Argh, stupid copy and paste bug, I really wanted to replace SUB and MUL
with MAD instead of ABS and SUB... This is btw another case where
brw_vs_tnl.c and t_vp_build.c differ, the former uses ABS where the
latter doesn't. I'd suspect both should use ABS if the input is depth
(that is, |eyez|), and maybe not if the input is from fog coord, though
behaviour doesn't seem to be well specified for negative fog coords
anyway and probably noone cares.
The bug should be fixed now.
Roland
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
