Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I've been doing a little work in Mesa's texture code lately.  I've
> mostly been resurrecting my old patch to implement MESAX_texture_stack.
>  In the process, I've found a few bits of code that could be refactored.
> 
> Attached are 4 patches.  I'd like to get an ACK or NAK on them before I
> commit.

Those look good (modulo the bug Alan found - nice catch!).

One minor nit: I'd replace GLuint with GLbitfield for the 
enable_texture() and is_texture_enabled() bit parameter.

That way, one can make a subtle distinction between 'bit' being a bit 
index vs. a bit flag/mask.

I'd be OK with these changes going into the 7.0 release.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to