On 2007.05.17 10:09:19 +0000, Keith Whitwell wrote: > Michel Dänzer wrote: > >On Thu, 2007-05-17 at 15:12 +0800, Wang Zhenyu wrote: > >>I've encountered problem when debugging rotation with DRI enabled. > >>I965 dri driver only checks sarea->ctxOwner when holding heavy lock, > >>but I think we also need to check it in light lock case, as ctxOwner > >>is used by video driver to tell others it's smashing the state. With > >>below patch, rotation can work fine with DRI on G965. > > > >It should not be necessary because the 2D driver should only touch the > >hardware state when it's holding the hardware lock, in which case the > >existing code should work fine. Maybe the real problem is that the 2D > >driver touches the hardware without taking the lock; I think somebody > >mentioned something like that on the xorg mailing list recently. > > > > > > Agreed. The most likely explanation for this is that somebody is > changing ctxOwner without properly grabbing the lock. >
oh, yes, sorry about that. Actually I've fixed in the driver, but still leave the mesa i965 dri change, which made me think it's needed. sorry for disturbing. :p ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
