On Sun, May 11, 2008 at 8:00 AM, George - <[EMAIL PROTECTED]> wrote: > > Hi, > > I did some cleanups and fixes and pushed the patches to: > > http://cgit.freedesktop.org/~gsap7/xserver/?h=drixorg > http://cgit.freedesktop.org/~gsap7/mesa/?h=drixorg > > I finally put the driver in drivers/dri/xorg. Note, however, that drixorg > implements the __DRIcoreExtension interface (as in drivers/dri/common), not > the > internal __DriverAPI interface ... > > I also documented some bugs I found by testing with some mesa demos > (see top of xorg.c), those happen in master also. > > The only stuff blocking merging should the configs extension and maybe > depth 8.
Wow, that's awesome work. My initial plan was to just wrap a dri interface around the XMesa driver, but this is much better. You drop the XMesa middle man and use the mesa internal API directly, which avoids hooking into the X server internals from XMesa. This also makes it much easier to load the sw dri driver from libGL. A few comments on the patches: 1. Can we call it swdri instead of drixorg? There's nothing xorg specific about it and the hw dri drivers also work with xorg. In fact, this makes it easy to load the sw driver from a non-X loader (say, EGL). 2. Create the __DRIconfigs in the drixorg driver and share the __DRIconfig conversion code in glxdri2.c in the xserver (and libGL). That's what the hw drivers do, because they know exactly what fbconfigs they can support. That's also true for the sw dri driver. 3. Just add a __DRISWExtension, along the lines of __DRIlegacyExtension instead of reusing the createScreen/createDrawable and createContext entry points from __DRIcoreExtension. This lets you pass in exactly the parameters required, and only those (instead of ignoring the unused fd and sarea handle). 4. Add a resizeDrawable entry point to the __DRISWExtension interface to be called when __glXDRIdrawableResize is called from the glx module. Not sure how to handle this when you load the sw dri driver on the client side, but you probably don't want to do that anyway... 5. Add yourself as copyright holder on the files you've authored :) cheers, Kristian ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
