On Tue, 2008-10-21 at 12:07 -0700, Eric Anholt wrote: > This fixes vblank support for a 32-bit X Server on a 64-bit kernel.
Thanks for tackling this, mea culpa for not testing it with 32 on 64 in the first place. > + if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) || > + __put_user(update32.handle, &request->handle) || > + __put_user(update32.type, &request->type) || > + __put_user(update32.num, &request->num) || > + copy_in_user(&request->data, &update32.data, sizeof(request->data))) > + return -EFAULT; AFAICT from the existing DRM 32 bit compatibility handlers, this could use __put_user() for the data member as well as possibly a single (__)copy_in_user() for all the members with identical layout in both cases. -- Earthling Michel Dänzer | http://tungstengraphics.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
