Markus Amsler wrote: > Corbin Simpson wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> The attached patches enable GL_EXT_fog_coord for r300, and also enable >> SW TCL to correctly route fog coordinates. This is sufficient to get fog >> coords working on the current git head. >> >> I'd like some review, because although it's a cool thought to think that >> just these few lines, plus the recent change in fragment program >> generation, magically make things work, I've fought against fog for too >> long to just assume that it's "that simple." :3 > > Nice, never imagined it could be that simple. > Wow on my r500 definitely looks a lot better with this patches :). > But with enabled fragment/vertex shaders the fog effect disappears. > > Also progs/tests/fogcoord doesn't work here.
Yeah, this basically only enables the fixed-function pipeline, but really, this was something I could never get reliably before. I think it's the recent changes that make the fixed-function stuff more solid. progs/tests/fog* don't work, but progs/demos/fogcoord does. > IIRC with enabled vertex/fragment shaders the fixed function fog stuff > is bypassed, and we should rewrite the shaders to emulate the fog > behaviour. > > Also the r500 specs mentions in section 6.5.1 : > Discrete Fog resides in one of Color 0-3 alpha. > > I'm not even sure Discrete Fog are fog coordinates. This is using the fixed-function fog slot. When doing PVS, fog coords should be stuffed into color 3's alpha. Also, when doing non-fixed frag shaders, Mesa should be adding the fog options to the fragment program; I'm going to look into whether or not that's viable. Oh, and I haven't tested on non-r5xx HW. I'll do that when I get home. ~ C. -- ~ Corbin Simpson <[EMAIL PROTECTED]> ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
