Corbin Simpson wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> The attached patches enable GL_EXT_fog_coord for r300, and also enable
> SW TCL to correctly route fog coordinates. This is sufficient to get fog
> coords working on the current git head.
> 
> I'd like some review, because although it's a cool thought to think that
> just these few lines, plus the recent change in fragment program
> generation, magically make things work, I've fought against fog for too
> long to just assume that it's "that simple." :3

Nice, never imagined it could be that simple.
Wow on my r500 definitely looks a lot better with this patches :).
But with enabled fragment/vertex shaders the fog effect disappears.

Also progs/tests/fogcoord doesn't work here.

IIRC with enabled vertex/fragment shaders the fixed function fog stuff 
is bypassed, and we should rewrite the shaders to emulate the fog behaviour.

Also the r500 specs mentions in section 6.5.1 :
        Discrete Fog resides in one of Color 0-3 alpha.

I'm not even sure Discrete Fog are fog coordinates.

Just some thoughts.

Markus

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to