On Mon, Nov 24, 2008 at 14:11, Jerome Glisse <[EMAIL PROTECTED]> wrote: > On Mon, 24 Nov 2008 12:51:08 +0100 > "RALOVICH, Kristóf" <[EMAIL PROTECTED]> wrote: > >> On Tue, Nov 18, 2008 at 18:05, RALOVICH, Kristóf >> <[EMAIL PROTECTED]> wrote: >> > On Wed, Nov 12, 2008 at 11:09, RALOVICH, Kristóf >> > <[EMAIL PROTECTED]> wrote: >> >> On Sat, Nov 8, 2008 at 18:40, RALOVICH, Kristóf >> >> <[EMAIL PROTECTED]> wrote: >> >>> On 2008-11-07, Brian Paul <[EMAIL PROTECTED]> wrote: >> >>>> On Thu, Nov 6, 2008 at 7:19 PM, RALOVICH, Kristóf >> >>>> >> >>>> <[EMAIL PROTECTED]> wrote: >> >>>> > On Thu, Nov 6, 2008 at 19:45, Kristian Høgsberg <[EMAIL PROTECTED]> >> >>>> wrote: >> >>>> >> On Thu, Nov 6, 2008 at 10:02 AM, RALOVICH, Kristóf >> >>>> >> <[EMAIL PROTECTED]> wrote: >> >>>> >>> On Wed, Nov 5, 2008 at 19:40, Kristian Høgsberg <[EMAIL >> >>>> PROTECTED]> wrote: >> >>>> >>>> On Tue, Nov 4, 2008 at 12:05 PM, RALOVICH, Kristóf >> >>>> >>>> <[EMAIL PROTECTED]> wrote: >> >>>> >>>>> Hi, >> >>>> >>>>> >> >>>> >>>>> these patches are against mesa/master. >> >>>> >>>>> >> >>>> >>>>> The code paths were compile and run tested. Running glxgears >> >>>> with Mesa >> >>>> >>>>> built with --enable-xcb yields some 5% speedup when indirect >> >>>> rendering >> >>>> >>>>> (~10000FPS -> ~10500FPS), however this is mostly meaningless. >> >>>> >>>>> >> >>>> >>>>> Comments are welcome! >> >>>> >>>> >> >>>> >>>> Sounds interesting - do you have a branch somewhere I can pull or >> >>>> can >> >>>> >>>> you send the patches inline so they're easier to review? >> >>>> >>>> >> >>>> >>>> thanks, >> >>>> >>>> Kristian >> >>>> >>>> >> >>>> >>> >> >>>> >>> Kristian, >> >>>> >>> >> >>>> >>> thanks for the reply! I will push to my fd.o repo, but since the >> >>>> XCB >> >>>> >>> folks advised me >> >>>> >>> >> >>>> (http://lists.freedesktop.org/archives/xcb/2008-November/004036.html), >> >>>> >>> this is not the way to go with implementing VendorPrivate requests >> >>>> I >> >>>> >>> have to revise and cleanup the series. >> >>>> >> >> >>>> >> Ok, thanks, I'll take a look there. >> >>>> >> >> >>>> >>> By the way if we are talking about the mesa glx sources, I think >> >>>> >>> finishing the indentation work is worth it. Maybe you could do it >> >>>> >>> instead of me, so you won't have any conflicts? >> >>>> >> >> >>>> >> I don't have any patches queued up right now, so you could redo the >> >>>> >> indenting if you want. I really wish we could get away from 3 space >> >>>> >> indents though... I feel hollow inside when I use that. >> >>>> > >> >>>> > I am ready to provide the patches, but if you prefer some other >> >>>> > indentation style I am not the right person to consult with. (Brian >> >>>> > maybe?) Since emacs is very flexible, I don't have a preference how >> >>>> > many spaces a tab shall be indented to. >> >>>> >> >>>> >> >>>> The SGI GLX code originally used 4-space indentation (with 8-space >> >>>> tabs). If you want to go back to that (w/out tabs, I'd prefer) in the >> >>>> GLX code, that's fine. >> >>>> >> >>>> Mesa proper uses 3-space indentation and will stay that way. >> >>>> >> >>>> >> >>>> -Brian >> >>>> >> >>> >> >>> I put together the branch I had promised: >> >>> git://people.freedesktop.org/~tade/mesa xcb-int2 or >> >>> http://cgit.freedesktop.org/~tade/mesa/log/?h=xcb-int2 on the web. >> >>> >> >>> The individual commits are not the most elegant ones, but the overall >> >>> diff is OK I guess. Please review! >> >>> >> >>> Thanks, >> >>> Kristof >> >>> >> >> >> >> Anyone willing to have a look at this? >> >> >> >> Thanks, >> >> Kristóf >> >> >> > >> > Would someone have a look at this please? >> > >> > Thanks, >> > Kristóf >> > >> >> Would someone please have a look at my patches and comment them? >> >> Thanks in advance, >> Kristóf > > Everyone fears that part of code :) I don't know much/at all this part of > code but i think if your patch don't break anythings then they sounds good, > using xcb sounds like a good plan. I can't give a better review than that > sorry. > > Cheers, > Jerome Glisse >
Thanks for the comment Jerome! I believe I have taken it very seriously to only make trivial changes that lie outside of the USE_XCB macro, mz opinion can't definitely be objective on this, but it is very unlikely for anything to break unless configuring with --enable-xcb which is not the default. Kristóf ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
