-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gary,

How much testing did you do on the noise code that you added to the 965
driver?  I modified Mesa's progs/glsl/noise.c demo to use NOISE3
opcodes, and it causes my GPU to hard-lock.  This is with today's bits
(kernel, Mesa, X server, and 2D driver).

I first encountered this when I was trying to add support for
OPCODE_NOISE4.  However, it occurs without any of my changes.

diff --git a/progs/glsl/noise.c b/progs/glsl/noise.c
index 9da71ac..d0a9b42 100644
- --- a/progs/glsl/noise.c
+++ b/progs/glsl/noise.c
@@ -30,7 +30,7 @@ static const char *FragShaderText =
    "   vec4 p;\n"
    "   p.xy = gl_TexCoord[0].xy;\n"
    "   p.z = Slice;\n"
- -   "   vec4 n = noise4(p * scale);\n"
+   "   vec4 n = noise4(p.xyz * scale.xyz);\n"
    "   gl_FragColor = n * Scale + Bias;\n"
    "}\n";

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkk/Ge8ACgkQX1gOwKyEAw/KjgCgkUZV+K3vk0UsgH/RB03aKIku
OnAAn2O8z/uTsfjeUiCQNkpXEFF3pCnf
=Wson
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to