On Sun, 2009-03-01 at 17:04 -0800, Pauli Nieminen wrote: > Here is improved implementation for buffered debug output when > hardware is locked. This version is untested because conversion is > still not ready. I just want some feed back if whole idea is shot down > and it is worthless to continue converting debug output. > > It includes all functional parts but is far from ready because many > parts of mesa are still waiting to be converted. > > Basic functionality is included in first patch. 11th patch includes > change to first and only dri driver converted so far. All less > interesting patches are in patches.tgz > > list of patch files: > 0001-Buffered-debbug-output-to-mesa.patch > 0002-Convert-messa-main-to-use-new-debug-output-functiona.patch > 0003-Convert-mesa-math-to-new-debug-output-format.patch > 0004-Convert-swrast-to-use-new-debug-output.patch > 0005-Convert-shader-compiler-to-use-new-debug-output-form.patch > 0006-Convert-state_tracker-to-use-new-debug-functions.patch > 0007-convert-tnl-to-use-new-debug-functions.patch > 0008-Convert-vf-to-use-new-debug-functions.patch > 0009-Convert-vbo-to-use-new-debug-functions.patch > 0010-Convert-tnl_dd-to-use-new-debug-functions.patch > 0011--Make-sis-dri-driver-to-use-new-debug-functions.patch > 0012-Fixing-random-conversion-mistakes.patch
Actually I'm pretty much against this, as it will break the typical debugging scenario that everybody has been using for many years -- ssh in from another machine and run gdb in the ssh session. If prints suddenly stop working in locked regions, that would be a big loss. For non-debug builds, locked prints should never occur & I'm happy to see that get cleaned up. However, I can't imagine any case where vbo/ tnl/ or shader-compiler ?!? code gets called with the lock held. If it does, that would be a bug in the r200 driver. Keith ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
