On Thu, 2009-03-05 at 08:45 -0800, Michel Dänzer wrote: > On Thu, 2009-03-05 at 08:37 -0800, Corbin Simpson wrote: > > > > Okay, so the commented-out code following that fallback is the blitter > > setup. It's simple, straightforward, and clean, but it requires a > > massive flush before and after, so I probably will toss it out. > > > > So surface_copy will eventually be done on the 3D engine instead. > > Note that I think this won't necessarily avoid the flushes, as the > render target will likely change before/after the surface_copy(). > > > This works terrifically, as long as there's no overlap between src and dest. > > As Jakob has reminded me, there's no guarantee made in Gallium regarding > > whether or not the src and dest will overlap in memory. > > The comment above util_blit_pixels_tex() says > > * Overlapping regions are acceptable. > > Although util_blit_pixels_tex may not be usable directly, if feasible I > think it would be nice to have some kind of default surface_copy > implementation using a textured quad, so that doesn't need to be > re-implemented in each driver. >
Agreed. In particular it should be possible for drivers to "play with themselves" during these types of operations, and then have a parental figure come in and clean things up afterwards. Keith ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
