On Mon, Oct 05, 2009 at 07:21:59PM -0700, Eric Anholt wrote: > > The third patch fixes a potential segfault. Calling a dynamic dispatch > > which is not supported by a DRI driver would crash an application. It > > is a bug of the application, since it should test the corresponding > > extension before calling such functions. But it is a simple fix to make > > such functions become no-op, just any static function that is not > > supported by the DRI driver. > Actually, I'd much rather see a consistent instruction error when > calling uninstalled dispatch. Since it uses the last offset (in the dynamic range) of the dispatch table, it is dispatched to generic_nop when there is a context. It prints a warning when MESA_DEBUG is set.
The dispatch may be modified by (pseudo code) SET_by_offset(ctx->Exec, _glapi_get_dispatch_table_size() - 1, unimplemented_dispatch) But I suppose generic_nop is enough? -- Regards, olv ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
