On Fri, 2009-10-09 at 07:10 -0700, Brian Paul wrote: > Keith Whitwell wrote: > > On Fri, 2009-10-09 at 06:19 -0700, michal wrote: > >> Keith Whitwell pisze: > >>> Michal, > >>> > >>> Sorry, this isn't a great way to do this. This can usually be caught > >>> much earlier in the pipeline and with much less overhead by validating > >>> the incoming index list. > >>> > >>> > >> OK, so we scan the whole element array beforehand, and if any element is > >> out of range, we kill the while primitive, right? > >> > >>> We normally do that in Mesa or the state tracker, if that helps. > >>> > >>> > >> Does this mean we actually don't want to check that in the draw module > >> and we should deal with it on the state tracker level? > > > > At a guess, yes. It would be helpful to have some tests to flush out > > the real issues, as you've gathered this has been a bit ignored to date. > > It seems to me there should probably be a pipe query to ask the driver > if it can do index bounds checking. If it can't, either the draw > module or state tracker will have to do it.
I don't think it needs to be a pipe-level interface -- it will change from time to time depending on swtnl fallback or not, for instance. I'd suggest making the draw module robust against failures and then providing an auxiliary library for drivers that need to validate before sending to hardware. In fact, if hardware is fragile like that, it's not even the driver that should be validating, but really the kernel module... Keith ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
