-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Brian Paul wrote: > Ian Romanick wrote: >> >> I'm in the process of adding support for vertex shaders generating clip >> distances. This is part of NV_vertex_program2 and GLSL 1.30. The >> natural way to do that is to add 6 entries to the gl_vert_result enum: >> one for each clip plane. However, doing so increases the number of >> vertex outputs from 31 to 37. This won't fit in a GLbitfield, and an >> assertion is triggered during context creation. >> >> My intention is to convert OutputsWritten from a GLbitfield to a >> uint64_t. This will precipitate a giant pile of changes across the >> whole *...@ing tree. Before I dive into this, is this the right way to >> do this? > > Yeah, I knew we'd need larger bitfields there eventually. > > I'd suggest defining a GLbitfield64 type (typedef of GLuint64) and > using that everywhere.
I was thinking about that. GL will probably need that someday anyway. > Some "ULL" suffixes will probably be needed here and there (like for > #define VERT_RESULT_CLIP_DIST0 (1ULL << 32)). I guess that's a C99 > feature but I think we're already going down that road. Does Visual Studio support that syntax? If so, that and GCC cover 99.99% of our users. > If/when someone complains that their system doesn't support 64-bit > types we can consider work-arounds. > > How does that sound? > > I suggest doing this on a feature branch. That's the plan. Some initial commits should show up today. I'll call the branch outputswritten64. Wish me luck. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkrYsjQACgkQX1gOwKyEAw9CZQCdGHt+X1442s5q36LdBH1tkWM/ HCoAoJ9Orcghjn063TpBh6QytHYGI3lv =n2wy -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
