>
>
> This is great stuff, and it couldn't have been in better timing. I was
> just about to get the python gallium tests we have working with llvmpipe
> too, and your work will save me a bunch of time.
>

You can also use the framework to write tests in C/C++, which, using a bit
of framework over gallium, like the included galliumut, may be easier than
using python.
I'm considering adding a simple testing framework at least to test some of
Nouveau's functionality, but I'm not making any guarantees.


> Instead of mesa/src/gallium/programs/ I'd prefer to have these on
> mesa/progs/gallium/, to keep the drivers/APIs in mesa/src samples/tests
> in mesa/progs. I'm going to move the python tests/examples from
> mesa/src/gallium/statetrackers/python/* to mesa/progs/gallium/python
> too.
>
I initially put it in there and later thought that it may be better to put
it in src/gallium so that all Mesa-independent Gallium code is entirely in
that directory. Also in some sense Gallium programs are state trackers in
executable form.
Move the code if you prefer that (it also needs a slight Makefile update to
conform for the auxiliary unification into libgallium.a)


> I also agree with Keith's comments about code formatting -- nobody wants
> to be pedantic about this, but Mesa is a joint project and once the code
> gets committed chances are it will be eventually modified by people
> besides the original author, and that's where code syntax consistency
> helps.
>
OK.
Of couse, I prefer the indenting I used. Tab indenting requires a single
keystroke and the visual impact can by configured easily by changing the
editor tab width. It also matches the Nouveau drivers and the kernel.
Anyway, just run indent on it, unless you actually find the argument
persuasive. I'll just teach Eclipse to do 3 space indenting (or ideally
autodetect indenting style).
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to