Marek Olšák wrote:
> Hi,
> 
> the first patch enables EXT_framebuffer_multisample in st/mesa. This 
> extension appears to alias ARB_fbo functions and there's no other 
> checking for multisampling in st/mesa where ARB_fbo is being enabled, so 
> fbo_multisample could be enabled by default.

That patch looks OK.


> The second patch enables hardware-accelerated CopyTex[Sub]Image in cases 
> when the RGB and RGBA destination formats are used regardless of source 
> formats. The idea is that if the colorbuffer is of RGB or RGBA format, 
> the format conversion for copying between two different surfaces is 
> basically done in texture units (using swizzles), therefore there is no 
> reason to use software fallback. Without this patch, openarena fallbacks 
> to software when bloom is enabled.

Did you read the comment at line 1498?  I remember specifically adding 
this check to fix some issues when copying an RGBA framebuffer to a 
RGB texture.

-Brian

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to