On Wed, Jan 20, 2010 at 4:53 PM, Kenneth Graunke <kenn...@whitecape.org> wrote:
>> Yes, that was why it was made permanent.  But I am in favor of making the
>> change to make the pipe transfer temporary right now.  I will leave it to
>> others who concern the performance of ximage backend enough to revert the
>> change :)
> Judging by the confusion, if ximage is to continue relying on softpipe
> specific behavior, it should probably at least include (more?) comments to
> that effect - how pipe transfers are normally temporary, but in this case,
> they're permanent because of (...).
> Otherwise, it stands as an example of how (not) to do things.  While it may be
> acceptable in this case, it should be made clear that it isn't OK in general.
That's right.  Actually, I have changed it to be temporary.  I have also added
a comment why it is temporary even if softpipe allows that to be permanent.

-olv

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to