-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kenneth Graunke wrote: > These patches remove various _mesa_foo() wrappers in favor of simply > calling foo() directly. I've split them out by function so it's > possible to pick and choose which ones to apply. Sorry for the spam. > > I figured I'd resend updated copies since Brian mentioned possibly > including them before the 7.8 release. > > The last three may break the SUNOS4 build, but I doubt anyone > cares seeing as the last release of that system was in 1994.
After reviewing the patches, I don't think those changes will break the SUNOS4 build. I think it will just cause a bunch of spurious warnings. I'm okay with that. You can add Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> on the whole series except 9 and 10. I think those patches should also eliminate the MEMCPY and MEMSET macros that wrap the wrappers. Unless there are objections, I'll apply patches 1 through 8 and 11 later today. Thanks for jumping on this so quickly! I'd also like to see additional patches to eliminate: - _mesa_bzero - Conditionally wrap this if HAVE_BZERO is not defined. Do the usual autoconf magic to detect it. Let non-autoconf builds figure it out there own way. - _mesa_bsearch. If we care about WinCE, we can give similar autoconf treatment for bsearch. - The math (_mesa_sin, _mesa_sinf, etc.) wrappers. Since the float versions exist on some implementations, this should get the same autoconf treatment as bzero. - _mesa_malloc, _mesa_calloc, _mesa_free, and especially _mesa_realloc. The other memory management wrappers provide useful functionality, so they should be kept. - _mesa_printf and friends. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkt+5uMACgkQX1gOwKyEAw99wQCdGz4BPjNTEEPRdeyVseo/+FS4 i8MAn2fPnIkIXutMPRT+QCXMhcKWKd8v =8hub -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
