George Sapountzis wrote: > On Tue, Feb 23, 2010 at 4:20 AM, Ian Romanick <i...@freedesktop.org> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> George Sapountzis wrote: >>> Hi, >>> >>> I put 3 patches in http://people.freedesktop.org/~gsap7/glapi/ that mv >>> the code generation functionality in the gen subdir. >>> >>> Please review, >> I'm curious... what is the reason for these changes? >> >> I do like the addition of the MESA_DIR and MESA_GLX_DIR variables. I >> also like the change of GLX_DIR to XORG_GLX_DIR. Patches making those >> changes could probably go in right away. I'd like a little explanation >> of why everything should be moved to a subdirectory before doing that. > > It does not move everything, but the API xml files and code generation > scripts. So, it is a clean-up that separates the code linked with > libGL from the code generation infrastructure. The result looks > cleaner here, so I'd like to push that as well if not strongly > opposed.
Looks pretty good to me. -Brian ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
